-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: fix bug cost model for tiflash do not work #13111
planner: fix bug cost model for tiflash do not work #13111
Conversation
Codecov Report
@@ Coverage Diff @@
## master #13111 +/- ##
=========================================
Coverage 80.174% 80.174%
=========================================
Files 468 468
Lines 110557 110557
=========================================
Hits 88638 88638
Misses 15136 15136
Partials 6783 6783 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a test?
@lamxTyler Test was added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
What problem does this PR solve?
As the title says.
What is changed and how it works?
Decouple the logic with hint
read_from_storage
.Check List
Tests
A simple test for after the PR: