Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner/core: do not change window ast when building plan (#12347) #12933

Merged
merged 2 commits into from
Oct 25, 2019
Merged

planner/core: do not change window ast when building plan (#12347) #12933

merged 2 commits into from
Oct 25, 2019

Conversation

XuHuaiyu
Copy link
Contributor

cherry-pick #12347

conflict file: logical_plan_test.go

@XuHuaiyu XuHuaiyu added type/bugfix This PR fixes a bug. sig/planner SIG: Planner needs-cherry-pick-3.0 labels Oct 25, 2019
@XuHuaiyu XuHuaiyu requested review from alivxxx and lzmhhh123 October 25, 2019 08:01
lzmhhh123
lzmhhh123 reviewed Oct 25, 2019
View reviewed changes
Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lzmhhh123 lzmhhh123 added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 25, 2019
alivxxx
alivxxx approved these changes Oct 25, 2019
View reviewed changes
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XuHuaiyu
Copy link
Contributor Author

/run-all-tests

@XuHuaiyu XuHuaiyu added status/LGT2 Indicates that a PR has LGTM 2. status/all tests passed and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 25, 2019
@zz-jason zz-jason merged commit b9632c4 into pingcap:release-3.0 Oct 25, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 25, 2019

cherry pick to release-3.0 failed

@XuHuaiyu XuHuaiyu deleted the restore-window branch October 25, 2019 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzmhhh123 lzmhhh123 lzmhhh123 left review comments

@alivxxx alivxxx alivxxx approved these changes

Assignees
No one assigned
Labels
sig/planner SIG: Planner status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@XuHuaiyu @sre-bot @alivxxx @lzmhhh123 @zz-jason