Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: implement vectorized evaluation for builtinJSONContainsSig #12924

Merged
merged 6 commits into from
Oct 29, 2019
Merged

expression: implement vectorized evaluation for builtinJSONContainsSig #12924

merged 6 commits into from
Oct 29, 2019

Conversation

js00070
Copy link
Contributor

@js00070 js00070 commented Oct 24, 2019

What problem does this PR solve?

implement vectorized evaluation for builtinJSONContainsSig for #12104

What is changed and how it works?

the performance enhancement depends on the input cases. Normally it will be about 5%~10% faster

BenchmarkVectorizedBuiltinJSONFunc/builtinJSONContainsSig-VecBuiltinFunc-12                16886             69849 ns/op               0 B/op          0 allocs/op
BenchmarkVectorizedBuiltinJSONFunc/builtinJSONContainsSig-NonVecBuiltinFunc-12             13544             88139 ns/op               0 B/op          0 allocs/op
BenchmarkVectorizedBuiltinJSONFunc/builtinJSONContainsSig-VecBuiltinFunc#01-12              2563            414056 ns/op          242515 B/op       1944 allocs/op
BenchmarkVectorizedBuiltinJSONFunc/builtinJSONContainsSig-NonVecBuiltinFunc#01-12           2517            442809 ns/op          243146 B/op       1944 allocs/op
BenchmarkVectorizedBuiltinJSONFunc/builtinJSONContainsSig-VecBuiltinFunc#02-12              2377            455628 ns/op          245552 B/op       1965 allocs/op
BenchmarkVectorizedBuiltinJSONFunc/builtinJSONContainsSig-NonVecBuiltinFunc#02-12           2354            484929 ns/op          245499 B/op       1965 allocs/op

Check List

Tests

  • Unit test

@js00070 js00070 requested a review from a team as a code owner October 24, 2019 17:42
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Oct 24, 2019
@ghost ghost requested review from wshwsh12 and removed request for a team October 24, 2019 17:42
@wshwsh12 wshwsh12 requested a review from qw4990 October 25, 2019 02:02
@imtbkcat
Copy link

/run-unit-test

@codecov
Copy link

codecov bot commented Oct 25, 2019 •
edited
Loading

Codecov Report

Merging #12924 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #12924   +/-   ##
===========================================
  Coverage   80.1033%   80.1033%           
===========================================
  Files           465        465           
  Lines        107812     107812           
===========================================
  Hits          86361      86361           
  Misses        14953      14953           
  Partials       6498       6498

Reminiscent
Reminiscent reviewed Oct 28, 2019
View reviewed changes
Copy link
Contributor

@Reminiscent Reminiscent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Reminiscent Reminiscent added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 28, 2019
qw4990
qw4990 approved these changes Oct 29, 2019
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 29, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 29, 2019

Your auto merge job has been accepted, waiting for 12922

@sre-bot
Copy link
Contributor

sre-bot commented Oct 29, 2019

/run-all-tests

@sre-bot sre-bot merged commit f3958c1 into pingcap:master Oct 29, 2019
@js00070 js00070 deleted the JSONContains branch November 7, 2019 11:09
XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
@js00070 @XiaTianliang
expression: implement vectorized evaluation for `builtinJSONContainsS…
e2077dd 
…ig` (pingcap#12924)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Reminiscent Reminiscent Reminiscent left review comments

@qw4990 qw4990 qw4990 approved these changes

@wshwsh12 wshwsh12 Awaiting requested review from wshwsh12

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@js00070 @imtbkcat @sre-bot @qw4990 @Reminiscent @wshwsh12