-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: implement vectorized evaluation for builtinJSONMergeSig
#12916
Conversation
/run-unit-test |
Codecov Report
@@ Coverage Diff @@
## master #12916 +/- ##
===========================================
Coverage 80.1577% 80.1577%
===========================================
Files 468 468
Lines 110018 110018
===========================================
Hits 88188 88188
Misses 15097 15097
Partials 6733 6733 |
@XuHuaiyu
the code which produces result.ReserveJSON(nr)
for i := 0; i < nr; i++ {
nullFlag := false
jsonVal := make([]json.BinaryJSON, 0, len(b.args))
for j := 0; j < len(b.args); j++ {
if argBuffers[j].IsNull(i) {
result.AppendNull()
nullFlag = true
break
}
jsonVal = append(jsonVal, argBuffers[j].GetJSON(i))
}
if !nullFlag {
result.AppendJSON(json.MergeBinary(jsonVal))
}
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, WELL DONE.
Your auto merge job has been accepted, waiting for 13003 |
/run-all-tests |
/run-all-tests |
What problem does this PR solve?
Implement vectorized evaluation for
builtinJSONMergeSig
mentioned in #12104What is changed and how it works?
about 40% faster
Check List
Tests