expression: implement vectorized evaluation for 'builtinCastDecimalAsJSONSig' #12803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
Codecov Report
@@ Coverage Diff @@
## master #12803 +/- ##
================================================
- Coverage 80.3562% 80.0649% -0.2913%
================================================
Files 465 462 -3
Lines 108416 105874 -2542
================================================
- Hits 87119 84768 -2351
+ Misses 14945 14784 -161
+ Partials 6352 6322 -30 |
SunRunAway
reviewed
Oct 17, 2019
expression/builtin_cast_vec.go
Outdated
| for i := 0; i < n; i++ { | ||
| if buf.IsNull(i) { | ||
| result.AppendJSON(json.BinaryJSON{}) | ||
| result.SetNull(i, true) |
There was a problem hiding this comment.
The JSON type is not fixed-length, although these code works fine for now,
I think we should call result.AppendNull here.
There was a problem hiding this comment.
OK, I had changed it.
SunRunAway
added
status/can-merge
|
/run-all-tests |
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Implement vectorized evaluation for builtinCastDecimalAsJSONSig, for #12104
What is changed and how it works?
Check List
Tests