Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: implement vectorized evaluation for 'builtinCastDurationAsJSONSig' #12797

Merged
merged 10 commits into from
Oct 31, 2019
Merged

expression: implement vectorized evaluation for 'builtinCastDurationAsJSONSig' #12797

merged 10 commits into from
Oct 31, 2019

Conversation

tsthght
Copy link
Contributor

@tsthght tsthght commented Oct 17, 2019

What problem does this PR solve?

Implement vectorized evaluation for builtinCastDurationAsJSONSig, for #12104

What is changed and how it works?

BenchmarkVectorizedBuiltinCastFunc/builtinCastDurationAsJSONSig-VecBuiltinFunc-8         	    2000	    643974 ns/op	  153402 B/op	    6955 allocs/op
BenchmarkVectorizedBuiltinCastFunc/builtinCastDurationAsJSONSig-NonVecBuiltinFunc-8      	    2000	    681645 ns/op	  153401 B/op	    6955 allocs/op

Check List

Tests

  • Unit test

@tsthght tsthght requested a review from a team as a code owner October 17, 2019 11:49
@ghost ghost requested review from wshwsh12 and removed request for a team October 17, 2019 11:49
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Oct 17, 2019
@wshwsh12 wshwsh12 requested a review from SunRunAway October 17, 2019 11:55
@codecov
Copy link

codecov bot commented Oct 17, 2019 •
edited
Loading

Codecov Report

Merging #12797 into master will increase coverage by 0.1509%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             master     #12797        +/-   ##
================================================
+ Coverage   80.0009%   80.1518%   +0.1509%     
================================================
  Files           468        468                
  Lines        109425     110121       +696     
================================================
+ Hits          87541      88264       +723     
+ Misses        15157      15141        -16     
+ Partials       6727       6716        -11

@qw4990
Copy link
Contributor

qw4990 commented Oct 22, 2019

@tsthght Friendly ping, please address comments.

@wshwsh12 wshwsh12 requested review from SunRunAway and qw4990 and removed request for wshwsh12 October 29, 2019 09:38
wshwsh12
wshwsh12 reviewed Oct 29, 2019
View reviewed changes
Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sre-bot
Copy link
Contributor

sre-bot commented Oct 31, 2019

@tsthght, please update your pull request.

qw4990
qw4990 approved these changes Oct 31, 2019
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added status/LGT2 Indicates that a PR has LGTM 2. status/can-merge Indicates a PR has been approved by a committer. and removed status/ReqChange labels Oct 31, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 31, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Oct 31, 2019

@tsthght merge failed.

@qw4990
Copy link
Contributor

qw4990 commented Oct 31, 2019

/run-all-tests

@qw4990
Copy link
Contributor

qw4990 commented Oct 31, 2019

/run-integration-compatibility-test

@qw4990
Copy link
Contributor

qw4990 commented Oct 31, 2019

/run-common-test

@wshwsh12
Copy link
Contributor

/run-integration-compatibility-test

1 similar comment
@wshwsh12
Copy link
Contributor

/run-integration-compatibility-test

SunRunAway
SunRunAway reviewed Oct 31, 2019
View reviewed changes
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsthght
Copy link
Contributor Author

tsthght commented Oct 31, 2019

/run-all-tests

1 similar comment
@wshwsh12
Copy link
Contributor

/run-all-tests

@qw4990
Copy link
Contributor

qw4990 commented Oct 31, 2019

/run-all-tests

@qw4990 qw4990 merged commit dc636af into pingcap:master Oct 31, 2019
XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
@tsthght @XiaTianliang
expression: implement vectorized evaluation for 'builtinCastDurationA…
78276c4 
…sJSONSig' (pingcap#12797)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wshwsh12 wshwsh12 wshwsh12 left review comments

@SunRunAway SunRunAway SunRunAway left review comments

@qw4990 qw4990 qw4990 approved these changes

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tsthght @qw4990 @sre-bot @wshwsh12 @SunRunAway