Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log: move autocommit varable value into connection info (#12310) #12568

Merged
merged 3 commits into from
Oct 13, 2019

Conversation

imtbkcat
Copy link

@imtbkcat imtbkcat commented Oct 9, 2019

What problem does this PR solve?

cherry-pick #12310
with conflict at https://github.com/pingcap/tidb/blob/release-3.1/executor/set.go#L190

@imtbkcat
Copy link
Author

/run-all-tests

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imtbkcat imtbkcat added status/all tests passed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 11, 2019
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 13, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 13, 2019

Your auto merge job has been accepted, waiting for 12404, 12602, 12671, 12490, 12565, 12593, 12672

@sre-bot
Copy link
Contributor

sre-bot commented Oct 13, 2019

/run-all-tests

@sre-bot sre-bot merged commit 155bff6 into pingcap:release-2.1 Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/usability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants