Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: add index speed metric (#12374) #12389

Merged
merged 2 commits into from
Oct 21, 2019

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Sep 25, 2019

cherry-pick #12374 to release-2.1


What problem does this PR solve?

Add a metric for DDL add index speed.
Related PR: pingcap/tidb-ansible#976

image

What is changed and how it works?

Check List

Code changes

  • Has exported function/method change

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note

  • Add a metric for DDL add index speed.

@sre-bot
Copy link
Contributor Author

sre-bot commented Sep 25, 2019

/run-all-tests

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 13, 2019
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 21, 2019
@ngaut ngaut added the status/can-merge Indicates a PR has been approved by a committer. label Oct 21, 2019
@sre-bot
Copy link
Contributor Author

sre-bot commented Oct 21, 2019

Your auto merge job has been accepted, waiting for 12390

@sre-bot
Copy link
Contributor Author

sre-bot commented Oct 21, 2019

/run-all-tests

@sre-bot sre-bot merged commit e584f43 into pingcap:release-2.1 Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/metrics status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/usability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants