add builtin-reverse func #1224

mrmiywj · 2016-05-11T19:28:07Z

CLAassistant · 2016-05-11T19:28:08Z

All committers have signed the CLA.

shenli · 2016-05-12T01:31:07Z

evaluator/builtin_string_test.go

+		Expect string
+	}{
+		{"abc", "cba"},
+		{"LIKE", "EKIL"},


Please add more cases such as reverse(null), reverse(123).

shenli · 2016-05-12T01:35:11Z

Please add test case for type inference here: https://github.com/pingcap/tidb/blob/master/optimizer/typeinferer_test.go#L35

shenli · 2016-05-12T01:41:44Z

Makefile

@@ -56,6 +56,7 @@ TEMP_FILE = temp_parser_file
 parser:
 	go get github.com/qiuyesuifeng/goyacc
 	go get github.com/qiuyesuifeng/golex
+	go get github.com/golang/example/stringutil


We use vendor to solve dependency. Should we add it into .vendor? @coocood

It's an example package, it's not supposed to be imported.

shenli · 2016-05-12T01:42:47Z

@mrmiywj Thanks for your contribute!

@coocood @zimulala @zxylvlp PTAL

coocood · 2016-05-12T02:32:18Z

@mrmiywj
Can you implement the simple function in stringutil directly?
So we don't have to import the package.

mrmiywj · 2016-05-12T03:55:27Z

cc @shenli @coocood

shenli · 2016-05-12T03:59:02Z

LGTM

coocood · 2016-05-12T05:11:16Z

parser/parser.y

+|       "REVERSE" '(' Expression ')'
+        {
+                $$ = &ast.FuncCallExpr{FnName: model.NewCIStr($1.(string)), Args: []ast.ExprNode{$3.(ast.ExprNode)}}
+        }


In parser.y and scanner.y, we use tab to align the code.
Please change spaces to tabs.

mrmiywj · 2016-05-12T05:32:23Z

cc @coocood
Sorry for that on my emacs configuration, tabs are automatically replaced by spaces

shenli · 2016-05-13T02:11:31Z

PTAL @coocood

shenli · 2016-05-13T02:54:55Z

parser/scanner.l

@@ -445,6 +445,7 @@ references	{r}{e}{f}{e}{r}{e}{n}{c}{e}{s}
 regexp		{r}{e}{g}{e}{x}{p}
 replace		{r}{e}{p}{l}{a}{c}{e}
 redundant	{r}{e}{d}{u}{n}{d}{a}{n}{t}
+reverse {r}{e}{v}{e}{r}{s}{e}


Seems it is not aligned.

mrmiywj · 2016-05-13T07:32:36Z

cc @shenli

coocood · 2016-05-13T08:49:09Z

@mrmiywj
Still use spaces, not aligned.

mrmiywj · 2016-05-13T11:02:10Z

cc @coocood

coocood · 2016-05-13T11:05:14Z

@mrmiywj
{reverse} lval.item = string(l.val) return reverse
in scanner.l

coocood · 2016-05-13T11:09:05Z

also missed a tab before line 2567

fix nits change spaces to tab fix indent fix indents fix indent

mrmiywj · 2016-05-13T12:10:36Z

cc @coocood

coocood · 2016-05-13T12:14:19Z

@mrmiywj
The alignment is ok now.
Please resolve the conflict.

mrmiywj · 2016-05-13T12:35:13Z

cc @coocood

coocood · 2016-05-13T12:53:36Z

LGTM
Thank you for your contribution!

…or GRANT CREATE USER ON <specific db>.* (pingcap#1224) * add StaticGlobalOnlyPrivs * fix

…or GRANT CREATE USER ON <specific db>.* (#1224) * add StaticGlobalOnlyPrivs * fix

shenli reviewed May 12, 2016
View reviewed changes

mrmiywj force-pushed the string-function-support branch from 23b56f1 to 7b92882 Compare May 12, 2016 03:55

coocood reviewed May 12, 2016
View reviewed changes

mrmiywj force-pushed the string-function-support branch from 7b92882 to 46029ea Compare May 12, 2016 05:31

shenli reviewed May 13, 2016
View reviewed changes

mrmiywj force-pushed the string-function-support branch from 46029ea to 6d324ca Compare May 13, 2016 06:31

mrmiywj force-pushed the string-function-support branch from 6d324ca to eea7690 Compare May 13, 2016 11:01

add builtin-reverse func

ee46ebf

fix nits change spaces to tab fix indent fix indents fix indent

mrmiywj force-pushed the string-function-support branch from eea7690 to ee46ebf Compare May 13, 2016 12:10

fix conflicts

3f19cf2

coocood merged commit 55ed68c into pingcap:master May 13, 2016

sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019

xhebox pushed a commit to xhebox/tidb that referenced this pull request Sep 28, 2021

[parser] parser: Fix tidb issue 24439 Inconsistent error with MySQL f…

7bf6deb

…or GRANT CREATE USER ON <specific db>.* (pingcap#1224) * add StaticGlobalOnlyPrivs * fix

xhebox pushed a commit to xhebox/tidb that referenced this pull request Oct 8, 2021

[parser] parser: Fix tidb issue 24439 Inconsistent error with MySQL f…

2a8f780

…or GRANT CREATE USER ON <specific db>.* (pingcap#1224) * add StaticGlobalOnlyPrivs * fix

ti-chi-bot pushed a commit that referenced this pull request Oct 9, 2021

[parser] parser: Fix tidb issue 24439 Inconsistent error with MySQL f…

3976830

…or GRANT CREATE USER ON <specific db>.* (#1224) * add StaticGlobalOnlyPrivs * fix

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add builtin-reverse func #1224

add builtin-reverse func #1224

mrmiywj commented May 11, 2016

CLAassistant commented May 11, 2016 •

edited

Loading

shenli May 12, 2016

shenli commented May 12, 2016 •

edited

Loading

shenli May 12, 2016

coocood May 12, 2016

shenli commented May 12, 2016

coocood commented May 12, 2016

mrmiywj commented May 12, 2016

shenli commented May 12, 2016

coocood May 12, 2016

mrmiywj commented May 12, 2016

shenli commented May 13, 2016

shenli May 13, 2016

mrmiywj commented May 13, 2016

coocood commented May 13, 2016

mrmiywj commented May 13, 2016

coocood commented May 13, 2016

coocood commented May 13, 2016 •

edited

Loading

mrmiywj commented May 13, 2016

coocood commented May 13, 2016

mrmiywj commented May 13, 2016

coocood commented May 13, 2016

add builtin-reverse func #1224

add builtin-reverse func #1224

Conversation

mrmiywj commented May 11, 2016

CLAassistant commented May 11, 2016 • edited Loading

shenli May 12, 2016

Choose a reason for hiding this comment

shenli commented May 12, 2016 • edited Loading

shenli May 12, 2016

Choose a reason for hiding this comment

coocood May 12, 2016

Choose a reason for hiding this comment

shenli commented May 12, 2016

coocood commented May 12, 2016

mrmiywj commented May 12, 2016

shenli commented May 12, 2016

coocood May 12, 2016

Choose a reason for hiding this comment

mrmiywj commented May 12, 2016

shenli commented May 13, 2016

shenli May 13, 2016

Choose a reason for hiding this comment

mrmiywj commented May 13, 2016

coocood commented May 13, 2016

mrmiywj commented May 13, 2016

coocood commented May 13, 2016

coocood commented May 13, 2016 • edited Loading

mrmiywj commented May 13, 2016

coocood commented May 13, 2016

mrmiywj commented May 13, 2016

coocood commented May 13, 2016

CLAassistant commented May 11, 2016 •

edited

Loading

shenli commented May 12, 2016 •

edited

Loading

coocood commented May 13, 2016 •

edited

Loading