-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: fix drop index failed when index contain auto_increment column and more than 2 index contain auto_increment_column #12230
Merged
Merged
Changes from 9 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
734cbea
ddl: fix drop index failed when index contain auto_increment column a…
crazycs520 0847a0d
address comment
crazycs520 21d3d13
Merge branch 'master' into fix-auto-index
crazycs520 2d23cc7
Merge branch 'fix-auto-index' of https://github.com/crazycs520/tidb i…
crazycs520 8cc0592
Merge branch 'master' into fix-auto-index
crazycs520 91ff895
Merge branch 'master' into fix-auto-index
crazycs520 350307b
Merge branch 'master' into fix-auto-index
crazycs520 e3870c3
Merge branch 'master' into fix-auto-index
crazycs520 6a47b9c
Merge branch 'master' into fix-auto-index
crazycs520 b6dd4bc
Merge branch 'master' into fix-auto-index
tangenta 25397f0
Merge branch 'master' into fix-auto-index
crazycs520 29ff01c
Merge branch 'master' into fix-auto-index
crazycs520 c3c82d4
Merge branch 'master' into fix-auto-index
crazycs520 1beebea
Merge branch 'master' into fix-auto-index
crazycs520 fdb220e
Merge branch 'master' into fix-auto-index
crazycs520 2af81dd
Merge branch 'master' into fix-auto-index
crazycs520 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we extract this code(line3400-3405) directly into a function instead of using
countOfIndexContainColumn
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, Done.