expression: support for testing a single vectorized evaluation function #12153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qw4990
reviewed
Sep 11, 2019
Co-Authored-By: Yuanjia Zhang <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #12153 +/- ##
===========================================
Coverage 81.1232% 81.1232%
===========================================
Files 454 454
Lines 98608 98608
===========================================
Hits 79994 79994
Misses 12850 12850
Partials 5764 5764 |
alivxxx
reviewed
Sep 11, 2019
# Conflicts: # expression/bench_test.go
zz-jason
reviewed
Sep 16, 2019
alivxxx
reviewed
Sep 17, 2019
|
@lamxTyler Update. PTAL |
Reminiscent
requested review from
zz-jason,
qw4990 and
alivxxx
and removed request for
SunRunAway and
XuHuaiyu
zz-jason
added
status/can-merge
|
/run-all-tests |
|
@Reminiscent merge failed. |
|
/run-unit-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Support for testing a single vectorized evaluation function.
What is changed and how it works?
Use
go test -argsto decide the test which function signature you want to run.For example, if you want to test the
builtinLog10SigandbuiltinSqrtSig. You can inputgo test -v -benchmem -bench=BenchmarkVectorizedBuiltinMathFunc -run=BenchmarkVectorizedBuiltinMathFunc -args "builtinLog10Sig" "builtinSqrtSig". Just input the function signature behind the "-args" flag. If you want to run all of the test, just ignore the "-args" flag.Check List
Tests