Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: implement vectorized evaluation for builtinIfJSONSig #12081

Merged
merged 3 commits into from
Sep 9, 2019
Merged

expression: implement vectorized evaluation for builtinIfJSONSig #12081

merged 3 commits into from
Sep 9, 2019

Conversation

Reminiscent
Copy link
Contributor

What problem does this PR solve?

Implement vectorized evaluation for builtinIfJSONSig.

What is changed and how it works?

BenchmarkVectorizedBuiltinFunc/builtinIfJSONSig-VecBuiltinFunc-4                  100000             16041 ns/op
BenchmarkVectorizedBuiltinFunc/builtinIfJSONSig-NonVecBuiltinFunc-4                30000             41022 ns/op

Check List

Tests

  • Unit test

@Reminiscent Reminiscent requested a review from qw4990 September 9, 2019 03:03
@codecov
Copy link

codecov bot commented Sep 9, 2019 •
edited
Loading

Codecov Report

Merging #12081 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #12081   +/-   ##
===========================================
  Coverage   81.5611%   81.5611%           
===========================================
  Files           448        448           
  Lines         96481      96481           
===========================================
  Hits          78691      78691           
  Misses        12215      12215           
  Partials       5575       5575

qw4990
qw4990 reviewed Sep 9, 2019
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SunRunAway
SunRunAway approved these changes Sep 9, 2019
View reviewed changes
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway SunRunAway added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels Sep 9, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 9, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Sep 9, 2019

/run-all-tests

@qw4990 qw4990 merged commit 15557df into pingcap:master Sep 9, 2019
@qw4990 qw4990 mentioned this pull request Sep 9, 2019
Closed
@zz-jason
Copy link
Member

zz-jason commented Sep 9, 2019

to #12058

@qw4990 qw4990 mentioned this pull request Sep 10, 2019
Closed
27 tasks
@Reminiscent Reminiscent deleted the builtinIfJSONGig branch December 24, 2019 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 left review comments

@SunRunAway SunRunAway SunRunAway approved these changes

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees
No one assigned
Labels
component/expression status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Reminiscent @sre-bot @zz-jason @SunRunAway @qw4990