planner: fix wrong request data type when pushing down avg aggfuncs #12051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #12051 +/- ##
===========================================
Coverage 81.5418% 81.5418%
===========================================
Files 447 447
Lines 95990 95990
===========================================
Hits 78272 78272
Misses 12162 12162
Partials 5556 5556 |
wshwsh12
force-pushed
the
fix_split_avg
branch
from
6c62725 to
fc28978
Compare
|
Is it hard to add unit test? |
Yes, I don't know how to add unit test. Any idea? |
|
We can build the plan refer to this. |
wshwsh12
force-pushed
the
fix_split_avg
branch
from
fc28978 to
4e7307d
Compare
|
/run-all-tests |
|
/run-unit-test |
|
I add unit test . PTAL @zz-jason @winoros @lzmhhh123 |
XuHuaiyu
added
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
When runing two
avg()in one sql, the request types of aggfuncs in DAGRequest maybe wrong. (Now tikv can work well, because of it has type deduction and ignore the wrong infomation.)What is changed and how it works?
Add a cursor to choose the right schema column.
Check List
Tests