Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: replace pessimistic default config option with global variable #12041

Merged
merged 5 commits into from
Sep 5, 2019

Conversation

coocood
Copy link
Member

@coocood coocood commented Sep 5, 2019

What problem does this PR solve?

The 'PessimisticTxn.Default' option in the Config requires a server restart to change.
It can be inconsistent for multiple servers.

What is changed and how it works?

  • Add global scope for tidb_txn_mode system variable.
  • Remove PessimisticTxn.Default option in the config.
  • Change the default value of PessimisticTxn.Enable to true.

Check List

Tests

  • Unit test

Code changes

  • Has exported variable/fields change

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update the tidb-ansible repository

Release note

  • Add global scope for tidb_txn_mode system variable, set enable option to 'true' and remove default option in the [pessimistic-txn] section of the config file.

@codecov
Copy link

codecov bot commented Sep 5, 2019

Codecov Report

Merging #12041 into master will decrease coverage by 0.1206%.
The diff coverage is 100%.

@@               Coverage Diff                @@
##             master     #12041        +/-   ##
================================================
- Coverage   81.4711%   81.3505%   -0.1207%     
================================================
  Files           447        447                
  Lines         95759      95649       -110     
================================================
- Hits          78016      77811       -205     
- Misses        12181      12303       +122     
+ Partials       5562       5535        -27

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiancaiamao
Copy link
Contributor

LGTM

@tiancaiamao tiancaiamao added the status/LGT2 Indicates that a PR has LGTM 2. label Sep 5, 2019
@AndreMouche AndreMouche added the status/can-merge Indicates a PR has been approved by a committer. label Sep 5, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 5, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Sep 5, 2019

@coocood merge failed.

@coocood
Copy link
Member Author

coocood commented Sep 5, 2019

/run-unit-test

@coocood coocood merged commit 0fbd21c into pingcap:master Sep 5, 2019
@coocood coocood deleted the pessimistic-global-var branch September 5, 2019 10:33
@sre-bot
Copy link
Contributor

sre-bot commented Sep 5, 2019

cherry pick to release-3.0 failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/transaction SIG:Transaction status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants