-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: replace pessimistic default config option with global variable #12041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #12041 +/- ##
================================================
- Coverage 81.4711% 81.3505% -0.1207%
================================================
Files 447 447
Lines 95759 95649 -110
================================================
- Hits 78016 77811 -205
- Misses 12181 12303 +122
+ Partials 5562 5535 -27 |
jackysp
reviewed
Sep 5, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
AndreMouche
approved these changes
Sep 5, 2019
AndreMouche
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
Sep 5, 2019
/run-all-tests |
@coocood merge failed. |
/run-unit-test |
cherry pick to release-3.0 failed |
This was referenced Sep 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
sig/transaction
SIG:Transaction
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT2
Indicates that a PR has LGTM 2.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
The 'PessimisticTxn.Default' option in the
Config
requires a server restart to change.It can be inconsistent for multiple servers.
What is changed and how it works?
tidb_txn_mode
system variable.PessimisticTxn.Default
option in the config.PessimisticTxn.Enable
to true.Check List
Tests
Code changes
Related changes
tidb-ansible
repositoryRelease note
tidb_txn_mode
system variable, setenable
option to 'true' and removedefault
option in the[pessimistic-txn]
section of the config file.