Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dml : fix last insert id when autoid specified by user in first row. (#11973) #12002

Merged
merged 2 commits into from
Sep 4, 2019
Merged

dml : fix last insert id when autoid specified by user in first row. (#11973) #12002

merged 2 commits into from
Sep 4, 2019

Conversation

AilinKid
Copy link
Contributor

@AilinKid AilinKid commented Sep 3, 2019

What problem does this PR solve?

cherry-pick #11973 to release-3.0

Check List

Tests

  • Unit test
  • Integration test

Release note

  • fix last insert id when autoid specified by user in first row.

@AilinKid AilinKid requested review from jackysp and lonng September 3, 2019 09:02
jackysp
jackysp reviewed Sep 4, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 4, 2019
lonng
lonng approved these changes Sep 4, 2019
View reviewed changes
Copy link
Contributor

@lonng lonng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AilinKid AilinKid added status/LGT2 Indicates that a PR has LGTM 2. status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 4, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 4, 2019

Sorry @AilinKid, you don't have permission to trigger auto merge event on this branch.

@AilinKid
Copy link
Contributor Author

AilinKid commented Sep 4, 2019

/rebuild

@AilinKid
Copy link
Contributor Author

AilinKid commented Sep 4, 2019

/run-all-tests

@winkyao winkyao merged commit 50ded87 into pingcap:release-3.0 Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp left review comments

@lonng lonng lonng approved these changes

Assignees
No one assigned
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AilinKid @sre-bot @lonng @jackysp @winkyao