Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix wrong partition boundary for window functions (#11637) #11825

Conversation

SunRunAway
Copy link
Contributor

Automated cherry pick of #11637 on release-3.0.
#11637: executor: fix wrong partition boundary for window
util: fix unit test

@SunRunAway SunRunAway requested review from alivxxx and zz-jason August 22, 2019 04:42
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added sig/execution SIG execution status/LGT1 Indicates that a PR has LGTM 1. type/3.0 cherry-pick labels Aug 22, 2019
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway
Copy link
Contributor Author

/run-all-tests

@SunRunAway SunRunAway added status/all tests passed status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels Aug 22, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Aug 22, 2019

Sorry @SunRunAway, you don't have permission to trigger auto merge event on this branch.

@ngaut ngaut removed the status/LGT1 Indicates that a PR has LGTM 1. label Aug 22, 2019
@ngaut ngaut changed the title executor: fix wrong partition boundary for window funcions (#11637) executor: fix wrong partition boundary for window functions (#11637) Aug 22, 2019
@ngaut ngaut merged commit bcd1d44 into pingcap:release-3.0 Aug 22, 2019
@SunRunAway SunRunAway deleted the automated-cherry-pick-of-#11637-upstream-release-3.0 branch August 22, 2019 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants