Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: fix date_add func in SECOND INTERVAL (#11312) #11616

Conversation

SunRunAway
Copy link
Contributor

Automated cherry pick of #11312 on release-2.1.
#11312: fix(types/time): deal negative number in second unit
test(expression/integration_test): add test case

@SunRunAway SunRunAway force-pushed the automated-cherry-pick-of-#11312-upstream-release-2.1 branch from 7236c63 to ad24f2e Compare August 5, 2019 09:25
@SunRunAway SunRunAway requested review from wshwsh12 and zz-jason August 5, 2019 09:26
@SunRunAway
Copy link
Contributor Author

@wshwsh12
It has a CI problem, it seems any pull request is not cherry-picked.

@wshwsh12
Copy link
Contributor

wshwsh12 commented Aug 5, 2019

@wshwsh12
It has a CI problem, it seems any pull request is not cherry-picked.

Ok, let me take a look. I seems that #11479 has not cherry-pick. Now I am trying to deal with it.

@wshwsh12
Copy link
Contributor

wshwsh12 commented Aug 6, 2019

Now I have cherry-picked the PR you need. Please resolve conflicts. And I think it will work well. @SunRunAway

@SunRunAway
Copy link
Contributor Author

/run-all-tests

@SunRunAway
Copy link
Contributor Author

@wshwsh12 @zz-jason PTAL again, thanks.

Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason merged commit 980f397 into pingcap:release-2.1 Aug 6, 2019
@zz-jason zz-jason added status/all tests passed status/LGT2 Indicates that a PR has LGTM 2. labels Aug 6, 2019
@SunRunAway SunRunAway deleted the automated-cherry-pick-of-#11312-upstream-release-2.1 branch August 6, 2019 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants