Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix baseExecutor'children may not be closed (#11570) #11576

Merged
merged 3 commits into from
Aug 5, 2019

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Aug 2, 2019

cherry-pick #11570 to release-3.0

@sre-bot
Copy link
Contributor Author

sre-bot commented Aug 2, 2019

/run-all-tests

@zimulala
Copy link
Contributor

zimulala commented Aug 3, 2019

PTAL @XuHuaiyu @lamxTyler

@zz-jason zz-jason requested review from XuHuaiyu and alivxxx August 5, 2019 02:56
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added status/LGT2 Indicates that a PR has LGTM 2. and removed status/all tests passed labels Aug 5, 2019
@zz-jason zz-jason added the status/can-merge Indicates a PR has been approved by a committer. label Aug 5, 2019
@alivxxx alivxxx added status/all tests passed status/can-merge Indicates a PR has been approved by a committer. and removed status/can-merge Indicates a PR has been approved by a committer. labels Aug 5, 2019
@sre-bot
Copy link
Contributor Author

sre-bot commented Aug 5, 2019

/run-all-tests

@sre-bot sre-bot merged commit 5d6bda6 into pingcap:release-3.0 Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants