-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tikv: invalidate store's regions when store be removed in kv #11567
Conversation
/run-all-tests |
/run-unit-test |
Codecov Report
@@ Coverage Diff @@
## master #11567 +/- ##
================================================
- Coverage 81.4916% 81.2105% -0.2812%
================================================
Files 427 426 -1
Lines 93196 91828 -1368
================================================
- Hits 75947 74574 -1373
- Misses 11862 11889 +27
+ Partials 5387 5365 -22 |
@coocood @tiancaiamao PTAL thx |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
cherry pick to release-3.0 failed |
Does this issue affect tidb v2.1.15? |
@dikang123 no, this issue only affect v3.0.0 and v3.0.1 |
What problem does this PR solve?
this question can be reproduced by
TestReplaceAddrWithNewStore
testcase:make sure 2-3 no any request hit region1, then 4 will be fail in infline loop
the root reason is: region-cache will try async fetch store A's new address but got nil, region request will keep retry and wait "new addr", this also will make cache TTL have no chance to invalidate cached info.
What is changed and how it works?
invalidate regions in removed store, to let request have the chance to reload new region's store info from pd.
after this modification,
TestReplaceAddrWithNewStore
can worksCheck List
Tests
Code changes
Side effects
Related changes
This change is