-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tikv: forbid to try to get a connection forever (#11391) #11531
Merged
Merged
+39
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please fix CI, @hicqu . |
jackysp
reviewed
Aug 2, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
lysu
previously approved these changes
Aug 2, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
lysu
added
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT2
Indicates that a PR has LGTM 2.
and removed
status/LGT1
Indicates that a PR has LGTM 1.
labels
Aug 2, 2019
/run-all-tests |
@hicqu merge failed. |
jackysp
added
status/can-merge
Indicates a PR has been approved by a committer.
and removed
status/can-merge
Indicates a PR has been approved by a committer.
labels
Aug 2, 2019
/run-all-tests |
@hicqu merge failed. |
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
jackysp
added
status/can-merge
Indicates a PR has been approved by a committer.
priority/release-blocker
This issue blocks a release. Please solve it ASAP.
and removed
status/can-merge
Indicates a PR has been approved by a committer.
labels
Aug 2, 2019
/run-all-tests |
jackysp
approved these changes
Aug 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/tikv
priority/release-blocker
This issue blocks a release. Please solve it ASAP.
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT2
Indicates that a PR has LGTM 2.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #11391