Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store/tikv, config: increase pessimistic ttl (#11499) #11521

Merged
merged 5 commits into from
Aug 2, 2019
Merged

store/tikv, config: increase pessimistic ttl (#11499) #11521

merged 5 commits into from
Aug 2, 2019

Conversation

coocood
Copy link
Member

@coocood coocood commented Jul 30, 2019

Cherry-pick: #11499

Conflict on config/config.go and store/tikv/2pc.go

@coocood
Copy link
Member Author

coocood commented Jul 30, 2019

/run-all-tests

@coocood coocood requested review from lysu, tiancaiamao and jackysp July 30, 2019 05:56
@jackysp
Copy link
Member

jackysp commented Jul 30, 2019

CI failed. @coocood

@coocood
Copy link
Member Author

coocood commented Jul 30, 2019

/run-all-tests

@tiancaiamao
Copy link
Contributor

/run-all-tests

lysu
lysu approved these changes Aug 2, 2019
View reviewed changes
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lysu
lysu suggested changes Aug 2, 2019
View reviewed changes
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need more reviewer- -

@lysu lysu added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 2, 2019
jackysp
jackysp approved these changes Aug 2, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp requested a review from lysu August 2, 2019 06:16
@coocood coocood added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 2, 2019
@lysu lysu added the status/can-merge Indicates a PR has been approved by a committer. label Aug 2, 2019
@coocood coocood merged commit 67a532f into pingcap:release-3.0 Aug 2, 2019
@coocood coocood deleted the increase-pessimistic-ttl-3.0 branch August 2, 2019 06:18
@coocood coocood changed the title store/tikv, config: increase pessimistic ttl store/tikv, config: increase pessimistic ttl (#11499) Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp approved these changes

@lysu lysu lysu approved these changes

@tiancaiamao tiancaiamao Awaiting requested review from tiancaiamao

Assignees
No one assigned
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@coocood @jackysp @tiancaiamao @lysu