Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDL: fix a bug in column charset and collate when create table and modify column (#11300) #11492

Merged
merged 4 commits into from
Jul 29, 2019

Conversation

AilinKid
Copy link
Contributor

@AilinKid AilinKid commented Jul 29, 2019

What problem does this PR solve?

Last cherry pick to release 3.0 has some error in IDC test (may be some mistakes in my cherry-pick operation), so I start a new one.
cherry-pick to release 3.0 #11300

Check List

Tests

  • Unit test
  • Integration test

@AilinKid
Copy link
Contributor Author

The mistake should be the modification of the cherry-pick title which is created automatically. Don't modify it!

@AilinKid AilinKid requested review from winkyao, bb7133, innerr, IzabelWang, iosmanthus and tangenta and removed request for innerr, IzabelWang and iosmanthus July 29, 2019 05:00
Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 changed the title DDL: fix a bug in column charset and collate when create table and mo… DDL: fix a bug in column charset and collate when create table and modify column (#11300) Jul 29, 2019
@AilinKid
Copy link
Contributor Author

/run-all-tests

Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 added status/LGT2 Indicates that a PR has LGTM 2. status/can-merge Indicates a PR has been approved by a committer. labels Jul 29, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Jul 29, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Jul 29, 2019

@AilinKid merge failed.

@AilinKid
Copy link
Contributor Author

/run-all-tests

Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AilinKid
Copy link
Contributor Author

/run-all-tests

@AilinKid
Copy link
Contributor Author

/rebuild

@zz-jason zz-jason merged commit 29210b9 into pingcap:release-3.0 Jul 29, 2019
@AilinKid AilinKid deleted the fix_collate_3.0_new branch July 29, 2019 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants