-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor, infoschema: fix display of on update CURRENT_TIMESTAMP with decimal #11480
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11480 +/- ##
=========================================
Coverage 81.486% 81.486%
=========================================
Files 426 426
Lines 93103 93103
=========================================
Hits 75866 75866
Misses 11853 11853
Partials 5384 5384 |
/LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-unit-test |
cherry pick to release-3.0 in PR #11591 |
cherry pick to release-2.1 failed |
What problem does this PR solve?
Fix #11349.
What is changed and how it works?
IsCurrentTimestampExpr
intoIsValidCurrentTimestampExpr
. Here "valid" means the fractional seconds precision in column type equals to the one inon update
clause.on update
clause whenshow create table
anddescribe
if necessary. For example, here is a table with the following schema:show create table t:
desc t:
Check List
Tests
Code changes
Related changes