Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: fix string to integer cast (#11295) #11469

Merged
merged 9 commits into from
Jul 29, 2019
Merged

types: fix string to integer cast (#11295) #11469

merged 9 commits into from
Jul 29, 2019

Conversation

amyangfei
Copy link
Contributor

@amyangfei amyangfei commented Jul 26, 2019 •
edited
Loading

cherry-pick #11295 to release-3.0, should be merged after #11471

@amyangfei amyangfei changed the title types: fix string to integer cast #11295 types: fix string to integer cast (#11295) (#10861) Jul 26, 2019
@amyangfei
Copy link
Contributor Author

/run-unit-tests

@amyangfei
Copy link
Contributor Author

/run-all-tests

@amyangfei
Copy link
Contributor Author

PTAL @zz-jason @qw4990

@zz-jason
Copy link
Member

It's better to cherry pick them one by one. So that we can tell which pr haven't cherry pick from git log

@amyangfei
Copy link
Contributor Author

It's better to cherry pick them one by one. So that we can tell which pr haven't cherry pick from git log

ok, let me re cherry pick

@amyangfei
Copy link
Contributor Author

amyangfei commented Jul 26, 2019 •
edited
Loading

It's better to cherry pick them one by one. So that we can tell which pr haven't cherry pick from git log

file another cherry pick #11471, CI failed is as wished.
After #11471 is merged, we can merge release-3.0 and reuse this pr?

@amyangfei amyangfei changed the title types: fix string to integer cast (#11295) (#10861) types: fix string to integer cast (#11295) Jul 26, 2019
zz-jason
zz-jason reviewed Jul 27, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason requested review from qw4990 and SunRunAway July 27, 2019 01:59
@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 27, 2019
@amyangfei amyangfei mentioned this pull request Jul 28, 2019
Merged
@zz-jason
Copy link
Member

/run-all-tests

1 similar comment
@zz-jason
Copy link
Member

/run-all-tests

@zz-jason
Copy link
Member

/run-unit-test

@zz-jason zz-jason mentioned this pull request Jul 29, 2019
Closed
@zz-jason
Copy link
Member

/run-unit-test

bb7133
bb7133 reviewed Jul 29, 2019
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason merged commit 384be78 into pingcap:release-3.0 Jul 29, 2019
@amyangfei amyangfei deleted the cast-int-fix-pick-3.0 branch July 29, 2019 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bb7133 bb7133 bb7133 left review comments

@zz-jason zz-jason zz-jason approved these changes

@qw4990 qw4990 Awaiting requested review from qw4990

@SunRunAway SunRunAway Awaiting requested review from SunRunAway

Assignees
No one assigned
Labels
component/expression status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amyangfei @zz-jason @bb7133