Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add trace support for subquery (#11182) #11458

Merged
merged 4 commits into from
Aug 1, 2019

Conversation

tiancaiamao
Copy link
Contributor

Cherry-pick #11182

This is a refactor(kind of) rather than a bug fix, but we'd better cherry-pick it to reduce further cherry-pick conflicts.

@tiancaiamao tiancaiamao added type/enhancement The issue or PR belongs to an enhancement. type/3.0 cherry-pick labels Jul 26, 2019
@tiancaiamao
Copy link
Contributor Author

/run-all-tests

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp
Copy link
Member

jackysp commented Jul 26, 2019

Please resolve the conflicts.

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 26, 2019
@jackysp
Copy link
Member

jackysp commented Jul 29, 2019

PTAL @lysu @coocood

@jackysp jackysp requested review from lysu and coocood July 29, 2019 04:40
@coocood
Copy link
Member

coocood commented Jul 29, 2019

LGTM

lysu
lysu previously approved these changes Jul 29, 2019
@zz-jason
Copy link
Member

@tiancaiamao Please resolve the conflicts.

@tiancaiamao tiancaiamao added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 31, 2019
@tiancaiamao
Copy link
Contributor Author

Done @zz-jason

@zz-jason
Copy link
Member

zz-jason commented Aug 1, 2019

conflicted again ..

@tiancaiamao
Copy link
Contributor Author

/rebuild

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/can-merge Indicates a PR has been approved by a committer. label Aug 1, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Aug 1, 2019

/run-all-tests

@sre-bot sre-bot merged commit 2ba7832 into pingcap:release-3.0 Aug 1, 2019
@tiancaiamao tiancaiamao deleted the trace-subquery branch August 9, 2019 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants