-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: add table info into context in fast plan case #11446
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11446 +/- ##
================================================
- Coverage 81.4907% 81.3566% -0.1342%
================================================
Files 424 424
Lines 92197 90815 -1382
================================================
- Hits 75132 73884 -1248
+ Misses 11743 11620 -123
+ Partials 5322 5311 -11 |
Codecov Report
@@ Coverage Diff @@
## master #11446 +/- ##
===========================================
Coverage 81.4095% 81.4095%
===========================================
Files 424 424
Lines 90923 90923
===========================================
Hits 74020 74020
Misses 11592 11592
Partials 5311 5311 |
@sdojjy Please add a UT. |
@zz-jason OK, I will add a UT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
cherry pick to release-2.1 in PR #11456 |
cherry pick to release-3.0 in PR #11457 |
What problem does this PR solve?
We forgot to add table info into session context in fast-plan case, so the audit log plugin can know which tabled is affected by the user.
What is changed and how it works?
Add table info when building PointGetPlan
Check List
Tests
step1: build and run tidb with audit plugin enabled.
step2: config the audit plugin
step 4: run point get, point update, point delete query.
step 3: check if the audit log containers the table info
Code changes
no
no
no
no
Related changes
cherry-pick to release 2.1