http: fix scatter table #11281
Merged
http: fix scatter table #11281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Leung <[email protected]>
|
Could tidb use pd client api for this http request? |
nolouch
approved these changes
Jul 17, 2019
|
@jackysp For now, we only support it by using HTTP API. But the answer may be yes later. |
Codecov Report
@@ Coverage Diff @@
## master #11281 +/- ##
===========================================
Coverage 81.2744% 81.2744%
===========================================
Files 423 423
Lines 90155 90155
===========================================
Hits 73273 73273
Misses 11577 11577
Partials 5305 5305 |
|
Should we cherry-pick this commit to release-2.1 and release-3.0? |
|
@XuHuaiyu Yes, we should. |
|
TiDB only needs one approval to merge to master, please don't approve it too early. @nolouch |
zz-jason
pushed a commit
that referenced
this pull request
Jul 18, 2019
zz-jason
pushed a commit
that referenced
this pull request
Jul 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Currently, the scatter table API cannot work well because the key in the HTTP request for the scatter table is not escaped. This PR is also related to tikv/pd#1642.
What is changed and how it works?
This PR fixes it by escaping the key.
Check List
Tests
Related changes