Function SUBTIME ADDTIME should return NULL with a warning if its argument is an invalid time value. #11262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11262 +/- ##
===========================================
Coverage 81.3855% 81.3855%
===========================================
Files 423 423
Lines 90607 90607
===========================================
Hits 73741 73741
Misses 11570 11570
Partials 5296 5296 |
tcmichael
changed the title
|
@SunRunAway PTAL |
SunRunAway
suggested changes
Jul 15, 2019
SunRunAway
added
component/expression
contribution
|
@SunRunAway PTAL |
tcmichael
force-pushed
the
bugfix-11175
branch
2 times, most recently
from
6b4cbbe to
364b912
Compare
lzmhhh123
reviewed
Jul 18, 2019
There was a problem hiding this comment.
@tcmichael Should we also consider other types of builtin_time like builtinSubStringAndDurationSig?
tcmichael
force-pushed
the
bugfix-11175
branch
2 times, most recently
from
efe6269 to
6b8f90f
Compare
… an invalid time value. (pingcap#11175)
|
@lzmhhh123 I tried to find out the functions of the same case, hoping that I found them all. |
lzmhhh123
approved these changes
Jul 19, 2019
|
@SunRunAway Please take a look. If ok, disable the change requested. |
|
/run-all-tests |
|
/run-all-tests |
|
cherry pick to release-2.1 failed |
|
cherry pick to release-3.0 in PR #11337 |
|
It seems that, not for sure, we failed to cherry-pick this commit to release-2.1. Please comment '/run-cherry-picker' to try to trigger the cherry-picker if we did fail to cherry-pick this commit before. @SunRunAway PTAL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Function SUBTIME ADDTIME should return NULL with a warning if its argument is an invalid time value.
Closes #11175
What is changed and how it works?
ignores ErrTruncatedWrongVal.
Check List
Tests