Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix bug when pruning columns for TableDual (#11054) #11247

Merged
merged 4 commits into from
Jul 15, 2019

Conversation

winoros
Copy link
Member

@winoros winoros commented Jul 15, 2019

What problem does this PR solve?

cherry-pick #11054

Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka eurekaka added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 15, 2019
Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@eurekaka
Copy link
Contributor

/run-all-tests

@eurekaka
Copy link
Contributor

@winoros CI failed, PTAL

@winoros
Copy link
Member Author

winoros commented Jul 15, 2019

/rebuild

@winoros
Copy link
Member Author

winoros commented Jul 15, 2019

@eurekaka fixed. It's something casued by environment.

@zz-jason zz-jason added priority/release-blocker This issue blocks a release. Please solve it ASAP. status/LGT2 Indicates that a PR has LGTM 2. status/all tests passed and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 15, 2019
@zz-jason zz-jason merged commit c705020 into pingcap:release-3.0 Jul 15, 2019
@winoros winoros deleted the pick1 branch September 5, 2019 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/release-blocker This issue blocks a release. Please solve it ASAP. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants