planner: fix NAME_CONST function compatibility #11241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11241 +/- ##
===========================================
Coverage 81.5069% 81.5069%
===========================================
Files 423 423
Lines 90883 90883
===========================================
Hits 74076 74076
Misses 11510 11510
Partials 5297 5297 |
Codecov Report
@@ Coverage Diff @@
## master #11241 +/- ##
================================================
- Coverage 81.6641% 81.2714% -0.3928%
================================================
Files 423 423
Lines 91591 90103 -1488
================================================
- Hits 74797 73228 -1569
- Misses 11512 11580 +68
- Partials 5282 5295 +13 |
zz-jason
added
sig/planner
|
/run-all-tests |
zz-jason
added
status/LGT1
SunRunAway
approved these changes
Jul 16, 2019
SunRunAway
added
status/LGT2
zz-jason
pushed a commit
that referenced
this pull request
Jul 18, 2019
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fix NAME_CONST error in negative value
closes 11146
What is changed and how it works?
rewrite value check method
Check List
Tests