Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: fix a bug for 'int column <cmp> non-int constant' (#11050) #11191

Merged
merged 1 commit into from
Jul 11, 2019
Merged

executor: fix a bug for 'int column <cmp> non-int constant' (#11050) #11191

merged 1 commit into from
Jul 11, 2019

Conversation

wshwsh12
Copy link
Contributor

cherry-pick: #11050

conflict:
expression/simple_rewriter.go

@wshwsh12 wshwsh12 added type/bugfix This PR fixes a bug. sig/execution SIG execution type/2.1 cherry-pick labels Jul 11, 2019
@wshwsh12
Copy link
Contributor Author

/run-all-tests

XuHuaiyu
XuHuaiyu reviewed Jul 11, 2019
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XuHuaiyu XuHuaiyu added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 11, 2019
zz-jason
zz-jason approved these changes Jul 11, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason merged commit 79eba3c into pingcap:release-2.1 Jul 11, 2019
@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu left review comments

@zz-jason zz-jason zz-jason approved these changes

Assignees
No one assigned
Labels
sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wshwsh12 @zz-jason @XuHuaiyu