Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: add some missing unit tests which exist in Coprocessor #10966

Merged
merged 3 commits into from
Jun 27, 2019
Merged

types: add some missing unit tests which exist in Coprocessor #10966

merged 3 commits into from
Jun 27, 2019

Conversation

lonng
Copy link
Contributor

@lonng lonng commented Jun 27, 2019

Signed-off-by: Lonng [email protected]

What problem does this PR solve?

Related PR: tikv/tikv#4962

types: add some missing unit tests which exist in Coprocessor

What is changed and how it works?

Check List

Tests

  • Unit test

@codecov
Copy link

codecov bot commented Jun 27, 2019

Codecov Report

Merging #10966 into master will decrease coverage by 0.0143%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             master     #10966        +/-   ##
================================================
- Coverage   80.9175%   80.9032%   -0.0144%     
================================================
  Files           418        418                
  Lines         89197      89193         -4     
================================================
- Hits          72176      72160        -16     
- Misses        11784      11798        +14     
+ Partials       5237       5235         -2

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 27, 2019
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazycs520
Copy link
Contributor

/run-all-tests

@lonng lonng added status/LGT2 Indicates that a PR has LGTM 2. status/all tests passed labels Jun 27, 2019
@lonng lonng merged commit fef22ae into pingcap:master Jun 27, 2019
@lonng lonng deleted the unit-tests branch June 27, 2019 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/test status/LGT1 Indicates that a PR has LGTM 1. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants