*: let baseFuncDesc.typeInfer return error instead of panic #10910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good job! |
XuHuaiyu
force-pushed
the
agg_panic_to_err
branch
from
87eaccc to
b69c823
Compare
Codecov Report
@@ Coverage Diff @@
## master #10910 +/- ##
=========================================
Coverage 81.359% 81.359%
=========================================
Files 419 419
Lines 90119 90119
=========================================
Hits 73320 73320
Misses 11580 11580
Partials 5219 5219 |
|
The explain test changed because of this line: This line should be |
|
Two issues need to be fixed after this commit: |
|
/run-all-tests |
|
/run-sqllogic-test-1 |
|
/run-sqllogic-test-1 |
XuHuaiyu
added a commit
to XuHuaiyu/tidb
that referenced
this pull request
Jun 23, 2019
XuHuaiyu
added a commit
to XuHuaiyu/tidb
that referenced
this pull request
Jun 23, 2019
XuHuaiyu
added
the
priority/release-blocker
crazycs520
reviewed
Jun 24, 2019
| └─IndexReader_19 8000.00 root index:StreamAgg_10 | ||
| └─StreamAgg_10 8000.00 cop group by:test.t1.a, test.t1.b, funcs:firstrow(test.t1.a), firstrow(test.t1.b) | ||
| └─IndexScan_17 10000.00 cop table:t1, index:a, b, range:[NULL,+inf], keep order:true, stats:pseudo | ||
| TableReader_9 10000.00 root data:TableScan_8 |
There was a problem hiding this comment.
Why this plan was changed?
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Before this commit, the following sql will make tidb-server panic.
Afer this commit,
What is changed and how it works?
Let baseFuncDesc.typeInfer return error instead of panic.
Check List
Tests
Code changes
Side effects
N/A
Related changes