Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: correct the parser dependency, and add tidy check #10878

Merged
merged 5 commits into from
Jun 20, 2019
Merged

go.mod: correct the parser dependency, and add tidy check #10878

merged 5 commits into from
Jun 20, 2019

Conversation

winkyao
Copy link
Contributor

@winkyao winkyao commented Jun 20, 2019

What problem does this PR solve?

Remove replace github.com/pingcap/parser => github.com/crazycs520/parser v0.0.0-20190619161234-4363da1ed757 in go.mod(merged by #10873 mistakenly)

add tidy_check.sh in release-2.1 to prevent merging incorrect go.mod PR. Ported from #8690

@tiancaiamao
Copy link
Contributor

LGTM

@tiancaiamao tiancaiamao added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 20, 2019
Copy link
Contributor

@lonng lonng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lonng lonng added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 20, 2019
@winkyao
Copy link
Contributor Author

winkyao commented Jun 20, 2019

/run-all-tests

@winkyao
Copy link
Contributor Author

winkyao commented Jun 20, 2019

/run-all-tests tidb-test=release-2.1 tidb-private-test=release-2.1 tikv=release-2.1

@zz-jason zz-jason merged commit 6d5f8f9 into pingcap:release-2.1 Jun 20, 2019
@winkyao winkyao deleted the add-check branch June 20, 2019 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/test status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants