-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
evaluator,parser: support ASCII() #1083
Conversation
@zyguan Thanks for your PR. Please sign the CLA. |
@shenli Sorry, I forgot it. |
@@ -2176,13 +2177,17 @@ Function: | |||
| FunctionCallAgg | |||
|
|||
FunctionNameConflict: | |||
"DATABASE" | "SCHEMA" | "IF" | "LEFT" | "REPEAT" | "CURRENT_USER" | "CURRENT_DATE" | "VERSION" | "UTC_DATE" | |||
"ASCII" | "DATABASE" | "SCHEMA" | "IF" | "LEFT" | "REPEAT" | "CURRENT_USER" | "CURRENT_DATE" | "VERSION" | "UTC_DATE" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ASCII is not a reserved keyword. It should not be here. You can put it into UnReservedKeyword rule: https://github.com/pingcap/tidb/blob/master/parser/parser.y#L1819
Ok, I put it there because of sql_yacc.yy. I'll fix it later. |
@shenli I see |
@zyguan I think it is a mistake. Good catch! |
LGTM |
LGTM |
@zyguan Thanks for your contribution! May I have your email address? |
@shenli Sure! [email protected] |
Thank you, This branch is out-of-date, Could you merge or rebase master ? @zyguan |
* evaluator: add a builtin function wanted by pingcap#310. * parser: update parser for ASCII().
@ngaut Yes, Of course! Wait a minute. |
Thanks @zyguan |
Hi, I'm reading the source code and willing to help to implement some basic builtin functions. However, I'm not sure if I did things right. Please correct me if I made mistake.