Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl, table: allow using SHARD_ROW_ID_BITS with auto_incremental columns (#10759) #10794

Merged
merged 2 commits into from
Jun 14, 2019
Merged

ddl, table: allow using SHARD_ROW_ID_BITS with auto_incremental columns (#10759) #10794

merged 2 commits into from
Jun 14, 2019

Conversation

bb7133
Copy link
Member

@bb7133 bb7133 commented Jun 13, 2019

Cherry-pick #10759

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update the tidb-ansible repository
  • Need to be included in the release note

@bb7133
Copy link
Member Author

bb7133 commented Jun 13, 2019

/run-all-tests

@bb7133
Copy link
Member Author

bb7133 commented Jun 13, 2019

PTAL @crazycs520 @coocood @tiancaiamao

jackysp
jackysp reviewed Jun 13, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiancaiamao
Copy link
Contributor

LGTM

@tiancaiamao tiancaiamao added the status/LGT2 Indicates that a PR has LGTM 2. label Jun 13, 2019
@winkyao winkyao merged commit 09fb804 into pingcap:release-3.0 Jun 14, 2019
@bb7133 bb7133 deleted the bb7133/cherry-pick_10759 branch December 29, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp left review comments

@tiancaiamao tiancaiamao tiancaiamao approved these changes

Assignees
No one assigned
Labels
status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bb7133 @tiancaiamao @jackysp @winkyao