Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: make the SyncerSessionTTL smaller (#10371) #10789

Merged
merged 2 commits into from
Jun 13, 2019
Merged

ddl: make the SyncerSessionTTL smaller (#10371) #10789

merged 2 commits into from
Jun 13, 2019

Conversation

zimulala
Copy link
Contributor

Cherry-pick #10371 to v2.1

@zimulala
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.1 tidb-private-test=release-2.1 tikv=release-2.1

crazycs520
crazycs520 reviewed Jun 13, 2019
View reviewed changes
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added status/LGT1 Indicates that a PR has LGTM 1. status/all tests passed labels Jun 13, 2019
@zimulala
Copy link
Contributor Author

PTAL @bb7133 @winkyao

bb7133
bb7133 reviewed Jun 13, 2019
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 13, 2019
winkyao
winkyao approved these changes Jun 13, 2019
View reviewed changes
Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winkyao winkyao merged commit 5f52742 into pingcap:release-2.1 Jun 13, 2019
@zimulala zimulala deleted the ttl-2.1 branch June 13, 2019 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazycs520 crazycs520 crazycs520 left review comments

@bb7133 bb7133 bb7133 left review comments

@winkyao winkyao winkyao approved these changes

Assignees
No one assigned
Labels
status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zimulala @bb7133 @winkyao @crazycs520