expression: fix issue that TimeIsNull
is not compatible with MySQL
#10753
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix #9763.
TimeIsNull
in TiDB doesn't check if these DATETIME columns are declared as NOT NULL.But In MySQL:
This PR needs to be merged after pingcap/tipb#121.
For TiKV, since
TimeIsNull
is not pushed down to TiKV, andtipb
intikv
tikv/tikv#4864) to lettipb
can't be upgraded in TiKV,we don't fix
TimeIsNull
on TiKV.What is changed and how it works?
Check if these DATETIME columns are declared as NOT NULL.
Check List
Tests