Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gc_worker: remove timezone name from the times that are saved in mysql.tidb (#8745) #10637

Merged
merged 5 commits into from
May 30, 2019

Conversation

XuHuaiyu
Copy link
Contributor

cherry-pick #8745

fix #10631

@XuHuaiyu XuHuaiyu requested review from qw4990 and winoros May 29, 2019 08:14
@XuHuaiyu XuHuaiyu requested a review from alivxxx May 29, 2019 09:11
@XuHuaiyu XuHuaiyu changed the title gc_worker: Remove timezone name from the times that are saved in mysql.tidb (#8745) gc_worker: remove timezone name from the times that are saved in mysql.tidb (#8745) May 29, 2019
@XuHuaiyu
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@XuHuaiyu
Copy link
Contributor Author

/run-integration-common-test tidb-test=release-2.1
/run-common-test tidb-test=release-2.1

Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added the status/LGT1 Indicates that a PR has LGTM 1. label May 29, 2019
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ngaut ngaut added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 30, 2019
@ngaut ngaut merged commit 80bea5a into pingcap:release-2.1 May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants