Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tikv: refine region-cache log and metric #10589

Merged
merged 3 commits into from
May 27, 2019
Merged

tikv: refine region-cache log and metric #10589

merged 3 commits into from
May 27, 2019

Conversation

lysu
Copy link
Contributor

@lysu lysu commented May 24, 2019

What problem does this PR solve?

add more accurate metric and log to observe and troubleshooting.

What is changed and how it works?

add metric and log

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • add log and metric

Side effects

  • N/A

Related changes

  • Need to cherry-pick to 3.0

This change is Reviewable

@lysu
Copy link
Contributor Author

lysu commented May 24, 2019

/run-all-tests

@codecov
Copy link

codecov bot commented May 24, 2019

Codecov Report

Merging #10589 into master will decrease coverage by 0.0195%.
The diff coverage is 100%.

@@               Coverage Diff                @@
##             master     #10589        +/-   ##
================================================
- Coverage   77.7107%   77.6911%   -0.0196%     
================================================
  Files           413        413                
  Lines         87504      87463        -41     
================================================
- Hits          68000      67951        -49     
- Misses        14356      14362         +6     
- Partials       5148       5150         +2

@lysu
Copy link
Contributor Author

lysu commented May 27, 2019

PTAL @jackysp @tiancaiamao thx

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winkyao winkyao merged commit 0c2696e into pingcap:master May 27, 2019
db-storage pushed a commit to db-storage/tidb that referenced this pull request May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants