ddl: validate table info before doing ddl job to avoid load infoschema error #10464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
winkyao
reviewed
May 15, 2019
ddl/column.go
Outdated
| @@ -242,6 +242,11 @@ func onDropColumn(t *meta.Meta, job *model.Job) (ver int64, _ error) { | |||
| colInfo.State = model.StateWriteOnly | |||
| // Set this column's offset to the last and reset all following columns' offsets. | |||
| adjustColumnInfoInDropColumn(tblInfo, colInfo.Offset) | |||
| err = checkTableInfoValid(tblInfo) | |||
There was a problem hiding this comment.
we should check if the tableInfo valid before we overwrite the tableInfo in TiKV.
There was a problem hiding this comment.
We have added check on line 265, why do it again?
Codecov Report
@@ Coverage Diff @@
## master #10464 +/- ##
================================================
+ Coverage 77.2657% 77.2906% +0.0248%
================================================
Files 413 413
Lines 86979 86986 +7
================================================
+ Hits 67205 67232 +27
+ Misses 14608 14594 -14
+ Partials 5166 5160 -6 |
bb7133
added
component/DDL-need-LGT3
status/LGT2
zimulala
reviewed
May 20, 2019
ddl/column.go
Outdated
| @@ -242,6 +242,11 @@ func onDropColumn(t *meta.Meta, job *model.Job) (ver int64, _ error) { | |||
| colInfo.State = model.StateWriteOnly | |||
| // Set this column's offset to the last and reset all following columns' offsets. | |||
| adjustColumnInfoInDropColumn(tblInfo, colInfo.Offset) | |||
| err = checkTableInfoValid(tblInfo) | |||
There was a problem hiding this comment.
We have added check on line 265, why do it again?
| @@ -1114,6 +1114,11 @@ func (d *ddl) CreateTableWithLike(ctx sessionctx.Context, ident, referIdent ast. | |||
| return errors.Trace(err) | |||
| } | |||
|
|
|||
| func checkTableInfoValid(tblInfo *model.TableInfo) error { | |||
There was a problem hiding this comment.
Do we need to add comments for it?
|
/run-all-tests |
zimulala
added
status/LGT3
crazycs520
added a commit
to crazycs520/tidb
that referenced
this pull request
May 20, 2019
winkyao
pushed a commit
that referenced
this pull request
May 20, 2019
db-storage
pushed a commit
to db-storage/tidb
that referenced
this pull request
May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Validate table info before doing ddl job to avoid load infoschema error.
eg1:
eg2:
What is changed and how it works?
Add check table info in create table and drop column.
Maybe add this check in other public path is better.
Check List
Tests
Code changes
Side effects
Possible performance regression
Related changes
Need to cherry-pick to the release branch