executor: should handle virtual columns when fetching duplicate rows in batchChecker #10370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackysp
added
status/WIP
type/bugfix
|
I'll add some cases tomorrow. |
Codecov Report
@@ Coverage Diff @@
## master #10370 +/- ##
================================================
+ Coverage 77.6497% 77.6695% +0.0198%
================================================
Files 412 411 -1
Lines 85547 85444 -103
================================================
- Hits 66427 66364 -63
+ Misses 14150 14116 -34
+ Partials 4970 4964 -6 |
Codecov Report
@@ Coverage Diff @@
## master #10370 +/- ##
================================================
+ Coverage 77.3876% 77.4078% +0.0201%
================================================
Files 412 412
Lines 85586 85596 +10
================================================
+ Hits 66233 66258 +25
+ Misses 14334 14324 -10
+ Partials 5019 5014 -5 |
Signed-off-by: Shuaipeng Yu <[email protected]>
Signed-off-by: Shuaipeng Yu <[email protected]>
Signed-off-by: Shuaipeng Yu <[email protected]>
Signed-off-by: Shuaipeng Yu <[email protected]>
|
/run-all-tests |
Signed-off-by: Shuaipeng Yu <[email protected]>
|
/run-all-tests |
amyangfei
added
status/LGT2
ngaut
approved these changes
May 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shuaipeng Yu [email protected]
What problem does this PR solve?
When fetching the duplicate rows in batchChecker, the virtual columns won't contribute to the dupKV map. So the replace/insert on duplicate will always find duplicate keys.
What is changed and how it works?
Should handle virtual columns when fetching duplicate rows in batchChecker.
Check List
Tests
Code changes
Side effects
Related changes