Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bindinfo: fix data race of parser in global handle #10321

Merged
merged 2 commits into from
Apr 30, 2019
Merged

bindinfo: fix data race of parser in global handle #10321

merged 2 commits into from
Apr 30, 2019

Conversation

alivxxx
Copy link
Contributor

@alivxxx alivxxx commented Apr 30, 2019

What problem does this PR solve?

Fix #10318

What is changed and how it works?

Use a new parser for newBindMeta and put it under lock.

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Side effects

  • None

Related changes

  • Need to cherry-pick to the release branch?

@alivxxx alivxxx added the type/bugfix This PR fixes a bug. label Apr 30, 2019
@alivxxx alivxxx requested review from lysu, zz-jason and XuHuaiyu April 30, 2019 03:27
@codecov
Copy link

codecov bot commented Apr 30, 2019 •
edited
Loading

Codecov Report

Merging #10321 into master will increase coverage by 0.0149%.
The diff coverage is 90.909%.

@@               Coverage Diff                @@
##             master     #10321        +/-   ##
================================================
+ Coverage   77.6649%   77.6798%   +0.0149%     
================================================
  Files           411        411                
  Lines         85444      85452         +8     
================================================
+ Hits          66360      66379        +19     
+ Misses        14122      14115         -7     
+ Partials       4962       4958         -4

zz-jason
zz-jason reviewed Apr 30, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 30, 2019
@zhouqiang-cl
Copy link
Contributor

/run-all-tests

lysu
lysu approved these changes Apr 30, 2019
View reviewed changes
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu lysu added status/LGT2 Indicates that a PR has LGTM 2. status/all tests passed and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 30, 2019
@zz-jason zz-jason merged commit cf0ca74 into pingcap:master Apr 30, 2019
@alivxxx alivxxx deleted the data-race branch April 30, 2019 05:41
@lysu lysu mentioned this pull request May 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@lysu lysu lysu approved these changes

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees
No one assigned
Labels
status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

data race in loadBindInfo
4 participants
@alivxxx @zhouqiang-cl @lysu @zz-jason