Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: refine point get failpoint injection logic #10319

Merged
merged 4 commits into from
Apr 30, 2019
Merged

executor: refine point get failpoint injection logic #10319

merged 4 commits into from
Apr 30, 2019

Conversation

lonng
Copy link
Contributor

@lonng lonng commented Apr 30, 2019

Signed-off-by: Lonng [email protected]

What problem does this PR solve?

Refine point get fault injection logic

What is changed and how it works?

  1. Change the failpoint expression from return(true) to return and remove debugger
  2. Refine the failpoint closure.

Check List

Tests

  • Unit test
  • Integration test

Code changes

N/A

Side effects

Related changes

@lonng lonng added the type/enhancement The issue or PR belongs to an enhancement. label Apr 30, 2019
@codecov
Copy link

codecov bot commented Apr 30, 2019

Codecov Report

Merging #10319 into master will increase coverage by 0.0129%.
The diff coverage is 100%.

@@               Coverage Diff                @@
##             master     #10319        +/-   ##
================================================
+ Coverage   77.6611%   77.6741%   +0.0129%     
================================================
  Files           411        411                
  Lines         85443      85421        -22     
================================================
- Hits          66356      66350         -6     
+ Misses        14122      14114         -8     
+ Partials       4965       4957         -8

@codecov
Copy link

codecov bot commented Apr 30, 2019 •
edited
Loading

Codecov Report

Merging #10319 into master will increase coverage by 0.0004%.
The diff coverage is 100%.

@@               Coverage Diff                @@
##             master     #10319        +/-   ##
================================================
+ Coverage   77.6701%   77.6705%   +0.0004%     
================================================
  Files           411        411                
  Lines         85455      85421        -34     
================================================
- Hits          66373      66347        -26     
+ Misses        14120      14114         -6     
+ Partials       4962       4960         -2

@jackysp jackysp requested a review from tiancaiamao April 30, 2019 06:21
@tiancaiamao
Copy link
Contributor

LGTM

@tiancaiamao tiancaiamao added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 30, 2019
@lonng
Copy link
Contributor Author

lonng commented Apr 30, 2019

@winkyao @jackysp PTAL

jackysp
jackysp approved these changes Apr 30, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp merged commit 667124b into pingcap:master Apr 30, 2019
@lonng lonng deleted the refine-point-get-failpoint branch April 30, 2019 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiancaiamao tiancaiamao tiancaiamao left review comments

@jackysp jackysp jackysp approved these changes

Assignees
No one assigned
Labels
status/LGT1 Indicates that a PR has LGTM 1. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lonng @tiancaiamao @jackysp