Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: fix issue that timestampadd is not compatible with Mysql #10314

Merged
merged 4 commits into from
May 5, 2019

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Apr 29, 2019

What problem does this PR solve?

Fix #9730

What is changed and how it works?

Resolve date type according to input type and unit.

Check List

Tests

  • Unit test

@codecov
Copy link

codecov bot commented Apr 29, 2019

Codecov Report

Merging #10314 into master will increase coverage by 0.0401%.
The diff coverage is 100%.

@@               Coverage Diff                @@
##             master     #10314        +/-   ##
================================================
+ Coverage   77.6622%   77.7023%   +0.0401%     
================================================
  Files           411        411                
  Lines         85389      85435        +46     
================================================
+ Hits          66315      66385        +70     
+ Misses        14110      14094        -16     
+ Partials       4964       4956         -8

@zhouqiang-cl
Copy link
Contributor

/rebuild

@zhouqiang-cl
Copy link
Contributor

/run-all-tests tidb-test=pr/795

@qw4990
Copy link
Contributor Author

qw4990 commented Apr 30, 2019

/rebuild

Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added the status/LGT1 Indicates that a PR has LGTM 1. label May 5, 2019
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 5, 2019
@zz-jason
Copy link
Member

zz-jason commented May 5, 2019

/run-all-tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

timestampadd is not compatible with Mysql
5 participants