doamin: fix GetSnapshotInfoSchema using current TS #10309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #10309 +/- ##
================================================
- Coverage 77.6692% 77.6691% -0.0001%
================================================
Files 411 411
Lines 85447 85429 -18
================================================
- Hits 66366 66352 -14
Misses 14118 14118
+ Partials 4963 4959 -4 |
|
PTAL @tiancaiamao @jackysp |
|
LGTM |
|
PTAL @XuHuaiyu |
tiancaiamao
added
status/LGT2
zimulala
added a commit
to zimulala/tidb
that referenced
this pull request
Apr 30, 2019
jackysp
pushed a commit
that referenced
this pull request
Apr 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
If the snapshotTS's schema version and
do.infoHandle.Get().SchemaMetaVersion()is equal in GetSnapshotInfoSchema, we will get the empty infoschema.What is changed and how it works?
I set
usedSchemaVersiontoinitialVersion, then the full load is needed.Check List
Tests
Related changes