expression: check timezone when encoding timestamp datum #10303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
|
/run-mybatis-test |
Codecov Report
@@ Coverage Diff @@
## master #10303 +/- ##
================================================
- Coverage 77.6781% 77.6714% -0.0068%
================================================
Files 411 411
Lines 85450 85451 +1
================================================
- Hits 66376 66371 -5
- Misses 14111 14118 +7
+ Partials 4963 4962 -1 |
|
/run-integration-common-test tidb-test=pr/794 |
winoros
reviewed
Apr 29, 2019
|
/rebuild |
|
@eurekaka there's a unit test failed in check_dev_2 though it passed in circle CI. |
|
/run-all-tests tidb-test=pr/794 |
1 similar comment
|
/run-all-tests tidb-test=pr/794 |
zimulala
added
status/LGT2
eurekaka
added
status/LGT2
erjiaqing
pushed a commit
to erjiaqing/tidb
that referenced
this pull request
May 5, 2019
zz-jason
pushed a commit
that referenced
this pull request
May 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix #10302
What is changed and how it works?
Convert timestamp datum to UTC timezone in
encodeDatum, to make it compatible withencodeandPBToExpr.Note that in code of coprocessor, there exists timezone conversion logic as well, see https://github.com/tikv/tikv/blob/2e1e20f7ced72a3333c2504fa4bfb53b44fe4b8a/src/coprocessor/dag/expr/mod.rs#L254 for details, so this change is compatible with TiKV.
Check List
Tests
Code changes
N/A
Side effects
N/A
Related changes