*: make config items Performance.*, OOMAction and MemQuotaQuery support hot-reloading
#10295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10295 +/- ##
================================================
- Coverage 77.7588% 77.7332% -0.0256%
================================================
Files 410 410
Lines 85117 85163 +46
================================================
+ Hits 66186 66200 +14
- Misses 13979 14014 +35
+ Partials 4952 4949 -3 |
qw4990
changed the title
Performance.XXX, OOMAction and MemQuotaQuery support hot-reloading
qw4990
changed the title
Performance.XXX, OOMAction and MemQuotaQuery support hot-reloadingPerformance.*, OOMAction and MemQuotaQuery support hot-reloading
alivxxx
reviewed
Apr 29, 2019
shenli
reviewed
Apr 29, 2019
zz-jason
reviewed
Apr 29, 2019
XuHuaiyu
reviewed
Apr 29, 2019
zz-jason
reviewed
Apr 29, 2019
XuHuaiyu
reviewed
Apr 29, 2019
jackysp
reviewed
Apr 29, 2019
jackysp
reviewed
Apr 29, 2019
|
/run-all-tests |
XuHuaiyu
added
component/server
status/all tests passed
status/LGT1
|
PTAL @lamxTyler @jackysp |
alivxxx
added
status/LGT2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Make some config items
Performance.*,OOMActionandMemQuotaQuerysupport hot-reloading.Performance.TCPKeepAliveandPerformance.StatsLeaseare not supported now.What is changed and how it works?
configpackage to let it support hot-reloading;All supported config items are defined in variable
hotReloadConfigItemsinmain.go;Check List
Tests