-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plugin:modify conn_ip_example's method parameters and return values #10288
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10288 +/- ##
================================================
+ Coverage 77.6625% 77.6716% +0.0091%
================================================
Files 411 411
Lines 85444 85452 +8
================================================
+ Hits 66358 66372 +14
+ Misses 14122 14120 -2
+ Partials 4964 4960 -4 |
@mantuliu Thanks! Please sign the CLA. |
@shenli done.Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What problem does this PR solve?
I recently researched TiDB's plugin mechanism, using the example provided by the official website (conn_id_example) to compile and generate plugins, but in the process of generating plugins, the following error message appears:
What is changed and how it works?
I checked and found that the OnGeneralEvent method in conn_id_example.go is different from the OnGeneralEvent method parameter and return value in plugin/audit.go. Therefore, this pull request modifies the conn_id_example.go method parameter and return value, so that it can be normal. Generate plugin: conn_ip_example-1.so.
Check List
Tests
Code changes
no
Side effects
no