Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: use EncodeBytes in countOriginDistinct (#10225) #10270

Merged
merged 2 commits into from
Apr 26, 2019
Merged

executor: use EncodeBytes in countOriginDistinct (#10225) #10270

merged 2 commits into from
Apr 26, 2019

Conversation

XuHuaiyu
Copy link
Contributor

cherry-pick #10225

@XuHuaiyu XuHuaiyu added type/bugfix This PR fixes a bug. sig/execution SIG execution type/2.1 cherry-pick labels Apr 25, 2019
@XuHuaiyu XuHuaiyu requested review from zz-jason and qw4990 April 25, 2019 09:03
@XuHuaiyu
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

eurekaka
eurekaka reviewed Apr 25, 2019
View reviewed changes
Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka
Copy link
Contributor

/run-common-test tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@eurekaka eurekaka added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 25, 2019
zz-jason
zz-jason approved these changes Apr 26, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 26, 2019
@zz-jason zz-jason merged commit 1138bd3 into pingcap:release-2.1 Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eurekaka eurekaka eurekaka left review comments

@zz-jason zz-jason zz-jason approved these changes

@qw4990 qw4990 Awaiting requested review from qw4990

Assignees
No one assigned
Labels
sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@XuHuaiyu @eurekaka @zz-jason